Update BDK to 1.0.0 and LDK to 0.1.0#426
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Jan 16, 2025
Merged
Conversation
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
8 times, most recently
from
aa745c6 to
115104c
Compare
This was referenced Jan 6, 2025
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
from
115104c to
4e31967
Compare
Collaborator
Author
|
Rebased on #429 to check it works (as other CI failures are fixed here). |
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
from
4e31967 to
d7eb1a1
Compare
jkczyz
reviewed
Jan 13, 2025
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
from
d7eb1a1 to
363dd0f
Compare
jkczyz
reviewed
Jan 14, 2025
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. Feel free to squash fixups.
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
from
363dd0f to
d7e3d67
Compare
Collaborator
Author
Squashed. I think we'll still need to wait |
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
from
d7e3d67 to
b8b9f01
Compare
Previously, we decided to continue parsing any fields if we failed to parse a known (i.e., `lightning` or `lno`) parameter failed to parse. This however just hides the error and is a bit anti-idiomatic even though allowing to use *some* URI fields even in the face of incompatible formats for others. Here we therefore opt to fail parsing the URI if any field fails.
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
from
b8b9f01 to
c39bfba
Compare
Collaborator
Author
|
@jkczyz Now updated the branch for final 0.1.0 release crates, and dropped the |
jkczyz
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We upgrade LDK and BDK to the latest releases.